Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "build: don't add libraries when --enable-static" #14893

Closed
wants to merge 1 commit into from
Closed

Revert "build: don't add libraries when --enable-static" #14893

wants to merge 1 commit into from

Conversation

bnoordhuis
Copy link
Member

Reverted for breaking the Windows build with the following error:

LINK : fatal error LNK1181: cannot open input file
'c:\workspace\node-compile-windows\label\win-vs2015\
Release\obj\node\gen\node_javascript.o'

This reverts commit be63c26.

cc @danbev - since this breaks the CI, I'd like to land this quickly.

@bnoordhuis
Revert "build: don't add libraries when --enable-static"
ef4c158 
Reverted for breaking the Windows build with the following error:

    LINK : fatal error LNK1181: cannot open input file
    'c:\workspace\node-compile-windows\label\win-vs2015\
    Release\obj\node\gen\node_javascript.o'

This reverts commit be63c26.
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Aug 17, 2017
danbev
danbev approved these changes Aug 17, 2017
View reviewed changes
Copy link
Contributor

@danbev danbev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about this. I'm running the build on windows now and will investigate what the issue is. Thanks

@bnoordhuis bnoordhuis closed this Aug 17, 2017
bnoordhuis added a commit to bnoordhuis/io.js that referenced this pull request Aug 17, 2017
@bnoordhuis
Revert "build: don't add libraries when --enable-static"
aa011a1 
Reverted for breaking the Windows build with the following error:

    LINK : fatal error LNK1181: cannot open input file
    'c:\workspace\node-compile-windows\label\win-vs2015\
    Release\obj\node\gen\node_javascript.o'

This reverts commit be63c26.

PR-URL: nodejs#14893
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@bnoordhuis
Copy link
Member Author

Thanks, landed in aa011a1.

@jasnell jasnell mentioned this pull request Oct 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aqrln aqrln aqrln approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bnoordhuis @danbev @aqrln @MylesBorins @nodejs-github-bot